It is preferable to to do a controlled shutdown prior to disconnecting
and eventually cutting of power to the drive.
BUG: 270808
Closes T9730
Details
Details
- Reviewers
ngraham broulik - Group Reviewers
Frameworks - Maniphest Tasks
- T9730: Spin down ejected hard drives
- Commits
- R245:867f53608d3a: [UDisks2] Power down drive on remove if supported
Connect external drive, select "Savely Remove" from context menu
- if drive has only on partition, fs is unmounted and drive spins down
- if drive has multiple partitions: a) first (not last) partition can be unmounted and remounted b) "Remove"ing last partition spins down drive
Diff Detail
Diff Detail
- Repository
- R245 Solid
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Works great with the unencrypted and LUKS-unencrypted single- and multi-partition ext4 disks that I tried out. Code change looks sane too. Wonderful work!
| src/solid/devices/backends/udisks2/udisksstorageaccess.cpp | ||
|---|---|---|
| 186 | Why this change? | |
Comment Actions
- do not create additional connections on the system bus
- avoid disconnecting optical drives, no need to power down
Comment Actions
Please wait till after Frameworks tagging (due tomorrow) so we can have more test exposure as Solid changes are usually quite delicate