| davidedmundson |
| KWin |
Missing from our surface handling was the damage_buffer call introduced in
version 4 of the wl_compositor interface.
Its only difference to a normal damage call is that the damaged region is
supposed to be defined by the client in buffer coordinates instead of
surface coordinates. This damage must be tracked separately in KWayland
and on commit with the buffer transformation united with the normal damage.
Autotest updated.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/client/surface.cpp | ||
|---|---|---|
| 244 | for (const QRect &r : region) { rects() is obsolete. http://doc.qt.io/qt-5/qregion-obsolete.html#rects | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 450 | scale is also a transform. Note also that the damage signal is used in kwin assuming it's surface local. | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 450 | Thanks! After applying the output transform and the scale transform, the damaged buffer region should be in surface local coordinates, right? I.e. the below sent damaged signal should then have the surface local damage. | |
| src/server/surface_interface.cpp | ||
|---|---|---|
| 453 | Should this last one be flipped 270? | |