Use system locale to display numbers in the scheduler.
ClosedPublic
Actions

Authored by TallFurryMan on Sep 30 2018, 8:09 PM.

Details

Reviewers

mutlaqja
wreissenberger

Commits

R321:c7dbd94c5590: Use system locale to display numbers in the scheduler.

Summary

Made XML serialization always use the C locale.
Displayed numbers based on locale in the job table.
Updated RA/DEC values in simple_test_no_twilight.esl with my own locale.
Homogeneized RA/DEC box display - no locale support planned in dmsBox yet.

Test Plan

Load scheduler test vector 'simple_test_no_twilight.esl'.
Check all target RA/DEC coordinates display properly.
Edit each target, re-open the object selection panel and re-select the same target.
Save the scheduler test vector, then re-load the scheduler test vector.
Without the change, depending on the locale, target coordinates are incorrect and only contain the integer part.
With the change, target coordinates are always matching their catalog reference.

Diff Detail

Repository

R321 KStars

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

TallFurryMan created this revision.Sep 30 2018, 8:09 PM

Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 30 2018, 8:09 PM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Harbormaster completed remote builds in B3374: Diff 42623.Sep 30 2018, 8:09 PM

TallFurryMan requested review of this revision.Sep 30 2018, 8:09 PM

mutlaqja accepted this revision.Oct 1 2018, 7:10 AM

This revision is now accepted and ready to land.Oct 1 2018, 7:10 AM

Closed by commit R321:c7dbd94c5590: Use system locale to display numbers in the scheduler. (authored by TallFurryMan, committed by mutlaqja). · Explain WhyOct 1 2018, 7:10 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			Tests/scheduler/simple_test_no_twilight.esl (44 lines)
M			kstars/ekos/scheduler/scheduler.cpp (58 lines)
M			kstars/ekos/scheduler/schedulerjob.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	42623	183d175		Sep 30 2018, 8:08 PM	★	★
Diff 2	42637	ab320a1	R321:c7dbd94c55903871bad9d7354b1efa5987b1623d	Oct 1 2018, 7:10 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
7a50981323f4	984626542c5b	dae7f3c5a5f6	Eric Dejouhanet	Pre-commit for arc-diff	Sep 30 2018, 8:38 AM
dae7f3c5a5f6	984626542c5b	ea4832c805be	Eric Dejouhanet	Homogeneized RA/DEC box display - no locale support planned there.	Sep 30 2018, 8:03 PM
ea4832c805be	1e616bf22e52	e76e645736e9	Eric Dejouhanet	Fix RA/DEC in simple_test_no_twilight.esl.	Sep 29 2018, 8:33 PM
e76e645736e9	ddc18ba3146d	dfb3054236bf	Eric Dejouhanet	Display numbers based on locale in the job table.	Sep 29 2018, 5:35 PM
dfb3054236bf	3c5f98793757	8d7818301415	Eric Dejouhanet	Make XML serialization always use the C locale.	Sep 29 2018, 5:31 PM
8d7818301415	9a5173100e81	183d1758ce82	Eric Dejouhanet	Use system locale to display numbers in the scheduler.	Sep 29 2018, 5:13 PM

Diff 42637

View Options

Tests/scheduler/simple_test_no_twilight.esl

View Options

kstars/ekos/scheduler/scheduler.cpp

View Options

kstars/ekos/scheduler/schedulerjob.cpp

Use system locale to display numbers in the scheduler.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 42637

Tests/scheduler/simple_test_no_twilight.esl

kstars/ekos/scheduler/scheduler.cpp

kstars/ekos/scheduler/schedulerjob.cpp

Use system locale to display numbers in the scheduler.
ClosedPublic
Actions

Revision Contents
Changeset List