Differential D15818

[Exe Thumbnailer] Ignore depth > 32
ClosedPublic
Actions

Authored by broulik on Sep 28 2018, 3:06 PM.

Details

Reviewers
anthonyfieroni
Commits
R320:5943efcfed8d: [Exe Thumbnailer] Ignore depth > 32
Summary

The depth information is read unaltered from the ico file and might be bogus. QImage::depth() claims that 32 is the largest supported value, so cap here.

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 28 2018, 3:06 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptSep 28 2018, 3:06 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 28 2018, 3:06 PM
anthonyfieroni accepted this revision.Sep 28 2018, 4:59 PM
This revision is now accepted and ready to land.Sep 28 2018, 4:59 PM
Closed by commit R320:5943efcfed8d: [Exe Thumbnailer] Ignore depth > 32 (authored by broulik). · Explain WhyOct 1 2018, 7:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mthumbnail/icoutils_common.cpp (2 lines)

Diff 42638

View Options

thumbnail/icoutils_common.cpp

Loading...