Differential D15787

[cli] Always take working dir into account when parsing url
ClosedPublic
Actions

Authored by nicolasfella on Sep 26 2018, 11:04 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:518251342cfe: [cli] Always take working dir into account when parsing url
Summary

Bug: 399115

When using kdeconnect-cli --share the first argument was not recognised as a file when a relative path was specified.

Test Plan

kdeconnect-cli --share File1.txt File2.txt : Check that both files are sent
kdeconnect-cli --sahre phabricator.kde.org : Check that web page is opend

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sep 26 2018, 11:04 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptSep 26 2018, 11:04 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Sep 26 2018, 11:04 PM
apol accepted this revision.Sep 27 2018, 1:19 AM
apol added a subscriber: apol.
apol added inline comments.
cli/kdeconnect-cli.cpp
151

like I said on the other, add QUrl::AssumeLocalFile.

This revision is now accepted and ready to land.Sep 27 2018, 1:19 AM
Closed by commit R224:518251342cfe: [cli] Always take working dir into account when parsing url (authored by nicolasfella). · Explain WhySep 28 2018, 1:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcli/kdeconnect-cli.cpp (2 lines)

Diff 42475

View Options

cli/kdeconnect-cli.cpp

Loading...