Depends on D15787
Restricting sharing multiple urls to files seems unnecessary to me.
Details
Details
- Reviewers
apol - Group Reviewers
KDE Connect - Commits
- R224:7a4bdcc62d32: [cli] Allow sharing files and URLs together
kdeconnect-cli --share foo.txt google.com
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| cli/kdeconnect-cli.cpp | ||
|---|---|---|
| 156 | while at it, pass a third argument being QUrl::AssumeLocalFile. Otherwise sometimes it decides you want to share http://myfile.odt. | |
| cli/kdeconnect-cli.cpp | ||
|---|---|---|
| 156 | But that would interpret google.com as a file, which is not what I would expect. If myfile.odt exists and is interpreted as http://myfile.odt that would be a bug in Qt. If myfile.odt doesn't exist it doesn't make sense sharing it, does it? | |
| cli/kdeconnect-cli.cpp | ||
|---|---|---|
| 156 | Maybe, but the fact that Qt has bugs doesn't make our life easier. Or leave it like that and we can test later. | |
Comment Actions
No strong opinions about this change, but I don't expect google.com to be interpreted as a URL actually.