Differential D15783

fix one typo in the Baloo invalid configuration notification
AbandonedPublic
Actions

Authored by mgallien on Sep 26 2018, 8:42 PM.

Details

Reviewers
aureliencouderc
astippich
januz
Summary

Thanks to Aurélien COUDERC for finding and reporting it.

Diff Detail

Repository
R255 Elisa
Branch
fixOneTypo
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3249
Build 3267: arc lint + arc unit
mgallien requested review of this revision.Sep 26 2018, 8:42 PM
mgallien created this revision.
astippich added a comment.Oct 7 2018, 1:54 PM

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

mgallien added a comment.Oct 7 2018, 2:03 PM
In D15783#338311, @astippich wrote:

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

You are completely true. I even had forgotten about this review and changed already the message. Sorry, I have really screwed this.

mgallien added a comment.Oct 7 2018, 2:05 PM
In D15783#338319, @mgallien wrote:
In D15783#338311, @astippich wrote:

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

You are completely true. I even had forgotten about this review and changed already the message. Sorry, I have really screwed this.

I would like to use the proposed message from the bug report:
"Cannot discover music with the current file search settings"

Do you think it is fine ?

astippich added a comment.Oct 7 2018, 2:10 PM
In D15783#338320, @mgallien wrote:
In D15783#338319, @mgallien wrote:
In D15783#338311, @astippich wrote:

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

You are completely true. I even had forgotten about this review and changed already the message. Sorry, I have really screwed this.

I would like to use the proposed message from the bug report:
"Cannot discover music with the current file search settings"

Do you think it is fine ?

Yes, I think that is a good one.

mgallien added a comment.Oct 7 2018, 2:15 PM
In D15783#338334, @astippich wrote:
In D15783#338320, @mgallien wrote:
In D15783#338319, @mgallien wrote:
In D15783#338311, @astippich wrote:

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

You are completely true. I even had forgotten about this review and changed already the message. Sorry, I have really screwed this.

I would like to use the proposed message from the bug report:
"Cannot discover music with the current file search settings"

Do you think it is fine ?

Yes, I think that is a good one.

Thanks for your help and sorry for screwing up this review.

mgallien abandoned this revision.Oct 7 2018, 2:17 PM
In D15783#338334, @astippich wrote:
In D15783#338320, @mgallien wrote:
In D15783#338319, @mgallien wrote:
In D15783#338311, @astippich wrote:

Is it really "incorrect"? I think for some users which may be concerned about resource usage of baloo it is a valid configuration option

You are completely true. I even had forgotten about this review and changed already the message. Sorry, I have really screwed this.

I would like to use the proposed message from the bug report:
"Cannot discover music with the current file search settings"

Do you think it is fine ?

Yes, I think that is a good one.

Thanks for your help and sorry for screwing up this review.

Revision Contents
Changeset List

Diff 42394

View Options

src/baloo/localbaloofilelisting.cpp

Loading...