Differential D15776

Show the preferred resolution on the combo box
ClosedPublic
Actions

Authored by apol on Sep 26 2018, 3:07 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R104:dfd178e6d093: Show the preferred resolution on the combo box
Summary

Usually there's a preferred resoluton for a display, let the user know it

Test Plan

Used the kcm with it, it's shown.

Diff Detail

Repository
R104 KScreen
Branch
preferredkcm
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3237
Build 3255: arc lint + arc unit
apol created this revision.Sep 26 2018, 3:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 26 2018, 3:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Sep 26 2018, 3:07 PM
davidedmundson accepted this revision.Sep 26 2018, 4:09 PM
davidedmundson added a subscriber: davidedmundson.

Code is neater. I like that.

Don't have an opinion on the icon, maybe tag VDG.

kcm/src/resolutionslider.cpp
71

I know you're not changing this, but this is rather broken.

You might have only a current mode or a preferred mode or both.

If you have both which one ends up selected by default is effectively arbitrary based on insertion order. (would require a monitor with a preferred mode that's smaller than the mode the user chose...but could happen I think?)

This revision is now accepted and ready to land.Sep 26 2018, 4:09 PM
ngraham added a subscriber: ngraham.Sep 26 2018, 4:35 PM

I think the favorite icon is just fine. 👍

Closed by commit R104:dfd178e6d093: Show the preferred resolution on the combo box (authored by Your Name <you@example.com>, committed by apol). · Explain WhySep 28 2018, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcm/src/resolutionslider.cpp (11 lines)

Diff 42374

View Options

kcm/src/resolutionslider.cpp

Loading...