This creates a warning message when one creates an attachment,
informing of KDE's use of Phabricator to submit patches, and to not
submit a patch through Bugzilla.
Per request of T6832.
ngraham | |
bcooksley |
Sysadmin |
This creates a warning message when one creates an attachment,
informing of KDE's use of Phabricator to submit patches, and to not
submit a patch through Bugzilla.
Per request of T6832.
No Linters Available |
No Unit Test Coverage |
Buildable 3163 | |
Build 3181: arc lint + arc unit |
The text is current set to be italicized ("emphasized"). Not sure if you'd prefer bold, or what. Let me know if you want a change.
Rather than using a hard do not submit patches here perhaps it might be better to say that Bugzilla is not monitored actively for patches, and that any patches uploaded here will be missed?
I would change "may be missed" to "is likely to be missed" to add a bit more certainty to it, since in point of fact, the patch is indeed likely to be missed judging by historical trends.
OK, actually simulating this for a user workflow, I think we need more changes to get the point across:
Basically, this is a good start but not enough: if we don't want people to submit patches on Bugzilla, we shouldn't make it look like we've gone out of our way to explicitly encourage and support that in the attachment UX.
+1, though I can't really test this. :) I'll defer to Sysadmin for code review here regarding the section that touches scripts.
This looks fine as far as I can tell.
If memory serves checkboxes only result in data being sent when they're checked, so this change should be totally safe.