Just a guess on how it can be ported. Will it be enough just use the common argv[0], argv[1], argv[2] arguments to slave() without parsing?
Details
Details
- Reviewers
lesliezhai aacid - Group Reviewers
KDE Applications - Commits
- R342:a18c914c776e: Port audiocd-kio away from kdelibs4support
- KIO can be compiled and installed.
- Dolphin understands audiocd:/ and the files from MP3, OGG, etc. subdirectories can be copied (extracted).
- K3b is not tested.
Diff Detail
Diff Detail
- Repository
- R342 KIO AudioCD
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Complete port to KF 5. Tested to work on audio CDs from my collection. Still unsure about the parsing of the command line in audiocd.cpp. Please help.
| audiocd.cpp | ||
|---|---|---|
| 84 | If this comment about libkcddb is true, this is going to be bad, needs to be a QApplication to be able to bring up widgets. | |
| audiocd.cpp | ||
|---|---|---|
| 90 | I'd say just use argv[x] directly like http.cpp and ftp.cpp do https://cgit.kde.org/kio.git/tree/src/ioslaves/http/http.cpp#n108 | |
| audiocd.cpp | ||
|---|---|---|
| 84 | It might be a very stupid question, but is it enough to change "QCoreApplication" to "QApplication"? I have tried to do so, but even after adding set(REQUIRED_QT_VERSION 5.9.0)
find_package(Qt5 ${REQUIRED_QT_VERSION} REQUIRED COMPONENTS Network Widgets)to CMakeLists.txt, it refuses to find QApplication for "#include <QApplication>". I'm lost. :'( | |
| audiocd.cpp | ||
|---|---|---|
| 84 | No, it's not enough. You also need to link against Qt5::Widgets in cmake (that will make the header file available for inclusion). | |
Comment Actions
I haven't tested it, but code seems sensible, so if you have tested it and are confident it works, i'd say go for it