Move away from kdebug and kdelibs4 in filter/sheets
ClosedPublic

Authored by dcaliste on Sep 20 2018, 12:54 PM.

Details

Summary

Like done by commit https://phabricator.kde.org/R8:50c327a76dc6edaa0137b1caf7e1e4e7afb3a531, use directly qDebug() in replacement of kDebug().

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dcaliste created this revision.Sep 20 2018, 12:54 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptSep 20 2018, 12:54 PM
dcaliste requested review of this revision.Sep 20 2018, 12:54 PM

This is old practice, please make a logging category -> https://doc.qt.io/qt-5/qloggingcategory.html

@anthonyfieroni I see, like in filters/sheets/html for instance. I'm going to update the diff as soon as ready. Thanks for the comment.

dcaliste updated this revision to Diff 41990.Sep 20 2018, 2:13 PM

Update the patch, using categories for logging.

leinir accepted this revision.Sep 24 2018, 11:20 AM

Yes please, categorification and less dependency on the support library is definitely a good thing :)

This revision is now accepted and ready to land.Sep 24 2018, 11:20 AM
This revision was automatically updated to reflect the committed changes.