It would only detect changes to existing device actions but not adding or removing them.
Moreover, the list of actions was never updated at runtime, only the list of predicates for the device.
This causes Device Notifier to pick up added, removed, or modified device actions only on startup.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R120:522d2cfce8ec: [Hotplug Engine] Update actions at runtime and listen for added/removed
- Added a device action, would show up in device notifier right away
- Renamed a device action, change would be reflected in device notifier right away
- Removed a device action, would disappear in device notifier right away
- Changed the predicate of an action to no longer match storage devices, it disappeared right away
- Invoking actions like "Open in file manager" still works
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Sorry, very naif review.
| dataengines/hotplug/hotplugengine.cpp | ||
|---|---|---|
| 152–153 | Don't we need to pass the icon and emblems here too? | |
| dataengines/hotplug/hotplugengine.cpp | ||
|---|---|---|
| 152–153 | I don't think so, the icon and emblem don't depend on the predicate but the device's state. Granted, we currently don't update them *at all* in this dataengine but that's a separate issue. Device Notifier actually queries those from the Solid Device data engine which does seem to update everything correctly. | |