Differential D1560

Marble Maps: Limit PinchArea to map view
ClosedPublic
Actions

Authored by kossebau on May 8 2016, 1:12 PM.

Details

Reviewers
nienhueser
Commits
R34:558039e162cd: Marble Maps: Limit PinchArea to map view
Summary

Pinching accidentally on the bottom dialog resulted in zooming of the map

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 3697.May 8 2016, 1:12 PM
kossebau retitled this revision from to Marble Maps: Limit PinchArea to map view.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added a reviewer: nienhueser.
kossebau updated this revision to Diff 3698.May 8 2016, 1:24 PM

Next try with basing against the other diff

rahn added a subscriber: rahn.Jul 9 2016, 11:54 AM

Looks good to me.

nienhueser edited edge metadata.Jul 9 2016, 3:20 PM

Patch doesn't apply here, but looks good. Please push.

nienhueser accepted this revision.Jul 9 2016, 3:20 PM
nienhueser edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 3:20 PM
Closed by commit R34:558039e162cd: Marble Maps: Limit PinchArea to map view (authored by kossebau). · Explain WhyJul 9 2016, 4:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/apps/marble-maps/MainScreen.qml (206 lines)

Diff 5042

View Options

src/apps/marble-maps/MainScreen.qml

Loading...