Differential D15537

displays a QMessageBox if no plugins are found
ClosedPublic
Actions

Authored by luansimoes on Sep 15 2018, 4:19 PM.

Details

Reviewers
tcanabrava
Group Reviewers
KDE Edu
Commits
R73:6ac9448a8599: displays a QMessageBox if no plugins are found

Diff Detail

Repository
R73 Rocs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
luansimoes created this revision.Sep 15 2018, 4:19 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 15 2018, 4:19 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
luansimoes requested review of this revision.Sep 15 2018, 4:19 PM
tcanabrava accepted this revision.Sep 17 2018, 7:53 AM
This revision is now accepted and ready to land.Sep 17 2018, 7:53 AM
Closed by commit R73:6ac9448a8599: displays a QMessageBox if no plugins are found (authored by luansimoes, committed by tcanabrava). · Explain WhySep 17 2018, 8:17 AM
This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Sep 18 2018, 5:38 PM

FWIW this is a very weird way to create a QMessageBox, one usually uses the static methods

tcanabrava added a comment.Sep 18 2018, 6:19 PM

The static variant didn't allowed to click in the link.

Em ter, 18 de set de 2018 às 19:38, Albert Astals Cid <
noreply@phabricator.kde.org> escreveu:

aacid added a comment. View Revision https://phabricator.kde.org/D15537

FWIW this is a very weird way to create a QMessageBox, one usually uses
the static methods

*REPOSITORY*
R73 Rocs

*REVISION DETAIL*
https://phabricator.kde.org/D15537

*To: *luansimoes, tcanabrava, KDE Edu
*Cc: *aacid, kde-edu, narvaez, apol

aacid added a comment.Sep 18 2018, 8:29 PM
In D15537#328146, @tcanabrava wrote:

The static variant didn't allowed to click in the link.

It should work, did you try wrapping it in <qt> markers?

Also you forgot i18n in the setText call

Revision Contents
Changeset List

Diff 41801

View Options

libgraphtheory/fileformats/fileformatmanager.cpp

Loading...