Introduce HKDF
ClosedPublic

Authored by volkov on Sep 14 2018, 4:23 PM.

Details

Summary

It's needed for implementation of Secret Service:
https://specifications.freedesktop.org/secret-service/ch07s03.html

Diff Detail

Repository
R486 QCA Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3637
Build 3655: arc lint + arc unit
volkov requested review of this revision.Sep 14 2018, 4:23 PM
volkov created this revision.
dfaure requested changes to this revision.Oct 7 2018, 6:29 PM
dfaure added a subscriber: dfaure.
dfaure added inline comments.
include/QtCrypto/qca_basic.h
1081

Missing class documentation.

Missing \since tag.

plugins/qca-botan/qca-botan.cpp
234

remove space after '('

250

override?

261

I'm allergic to C casts, after seeing them misused. Would static_cast work here? Otherwise reinterpret_cast?

This revision now requires changes to proceed.Oct 7 2018, 6:29 PM
volkov added inline comments.Oct 8 2018, 11:15 AM
plugins/qca-botan/qca-botan.cpp
250

it still supports build with Qt 4 and without C++ 11

volkov updated this revision to Diff 43125.Oct 8 2018, 11:27 AM

more reinterpret_casts

BTW, should I create a review request to reformat code with astyle-kdelibs?

dfaure accepted this revision.Oct 14 2018, 9:25 AM

I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code.

This revision is now accepted and ready to land.Oct 14 2018, 9:25 AM
volkov closed this revision.Oct 15 2018, 11:31 AM

This has made the FreeBSD CI builds unhappy unfortunately:
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.11/15/console

Due to various issues, QCA isn't built on the Linux CI systems so there may be other issues there which only packagers will hit when this is released.