Introduce HKDF
ClosedPublic
Actions

include/QtCrypto/qca_basic.h
1081	Missing class documentation. Missing \since tag.
plugins/qca-botan/qca-botan.cpp
234	remove space after '('
250	override?
261	I'm allergic to C casts, after seeing them misused. Would static_cast work here? Otherwise reinterpret_cast?

This revision now requires changes to proceed.Oct 7 2018, 6:29 PM

volkov added inline comments.Oct 8 2018, 11:15 AM

plugins/qca-botan/qca-botan.cpp
250	it still supports build with Qt 4 and without C++ 11

fixed

Harbormaster completed remote builds in B3636: Diff 43123.Oct 8 2018, 11:18 AM

more reinterpret_casts

Harbormaster completed remote builds in B3637: Diff 43125.Oct 8 2018, 11:27 AM

BTW, should I create a review request to reformat code with astyle-kdelibs?

I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code.

This revision is now accepted and ready to land.Oct 14 2018, 9:25 AM

volkov closed this revision.Oct 15 2018, 11:31 AM

This has made the FreeBSD CI builds unhappy unfortunately:
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Applications%20stable-kf5-qt5%20FreeBSDQt5.11/15/console

Due to various issues, QCA isn't built on the Linux CI systems so there may be other issues there which only packagers will hit when this is released.

D16248

Revision Contents
Changeset List

			Path	Packages
M			include/QtCrypto/qca_basic.h (57 lines)
M			include/QtCrypto/qcaprovider.h (34 lines)
M			plugins/qca-botan/qca-botan.cpp (46 lines)
M			plugins/qca-ossl/qca-ossl.cpp (33 lines)
M			src/qca_basic.cpp (31 lines)
M			unittest/kdfunittest/kdfunittest.cpp (55 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	41656	98eead0		Sep 14 2018, 4:23 PM	★	★
Diff 2	43123	98eead0	fixed	Oct 8 2018, 11:17 AM	★	★
Diff 3	43125	98eead0	more reinterpret_casts	Oct 8 2018, 11:26 AM	★	★