[Bookmarks Runner] Expose list of tables from FetchSqlite
ClosedPublic

Authored by bruns on Sep 13 2018, 8:46 PM.

Details

Summary

This is a preparatory patch required for further rework

Test Plan

make

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Sep 13 2018, 8:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 13 2018, 8:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bruns requested review of this revision.Sep 13 2018, 8:46 PM
davidedmundson requested changes to this revision.Sep 13 2018, 9:43 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
runners/bookmarks/fetchsqlite.cpp
104

please guard this with the mutex

106

you're shadowing m_db

it'll never be open

This revision now requires changes to proceed.Sep 13 2018, 9:43 PM
bruns updated this revision to Diff 41588.Sep 13 2018, 10:14 PM

scrap spurious line
lock mutex

davidedmundson accepted this revision.Sep 13 2018, 10:26 PM
This revision is now accepted and ready to land.Sep 13 2018, 10:26 PM
This revision was automatically updated to reflect the committed changes.