Differential D15468

[server] Do not return early on fail in touchDown fall back code
ClosedPublic
Actions

Authored by romangg on Sep 13 2018, 8:17 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Frameworks
Commits
R127:3cf4825c8050: [server] Do not return early on fail in touchDown fall back code
Summary

Returning early would mean that SeatInterface::Private::touchInterface.ids
does not contain the id. Then the assert would fail in touchUp at some
point later when called by the compositor.

Diff Detail

Repository
R127 KWayland
Branch
fixEarlyTouchDownExit
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 2784
Build 2802: arc lint + arc unit
romangg created this revision.Sep 13 2018, 8:17 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 13 2018, 8:17 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
romangg requested review of this revision.Sep 13 2018, 8:17 AM
davidedmundson accepted this revision.Sep 13 2018, 10:04 PM
This revision is now accepted and ready to land.Sep 13 2018, 10:04 PM
Closed by commit R127:3cf4825c8050: [server] Do not return early on fail in touchDown fall back code (authored by romangg). · Explain WhySep 18 2018, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/server/seat_interface.cpp (5 lines)

Diff 41514

View Options

src/server/seat_interface.cpp

Loading...