Differential D15464

[server] Touch drag support
ClosedPublic
Actions

Authored by romangg on Sep 12 2018, 8:26 PM.

Tags

Subscribers

davidedmundson, kde-frameworks-devel

Details

Reviewers

Group Reviewers

KWin
Frameworks

Commits

R127:09b5adee94ad: [server] Touch drag support

Summary

Adds functionality to do drag and drop with touch screens.

Test Plan

Manually. Autotest planned.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Sep 12 2018, 8:26 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2018, 8:26 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

romangg requested review of this revision.Sep 12 2018, 8:26 PM

Harbormaster completed remote builds in B2778: Diff 41503.Sep 12 2018, 8:26 PM

romangg added a dependency: D15443: [server] Allow multiple touch interfaces per client.Sep 12 2018, 8:28 PM

romangg added a dependent revision: D15466: Add Wayland touch drag and drop support.Sep 12 2018, 8:33 PM

davidedmundson added a subscriber: davidedmundson.Sep 12 2018, 8:49 PM

davidedmundson added inline comments.

src/server/datadevice_interface.cpp
101–102	done
src/server/seat_interface.cpp
1349	If I add 2 IDs [0,1] then remove ID 0 [1] with the old code I would get the ID 2, with this I'll get a second ID 1
1413	I expect you need this in touchCancel too
src/server/seat_interface_p.h
154	If you don't need the order QHash over QMap

romangg marked 3 inline comments as done.Sep 19 2018, 12:33 AM

romangg added inline comments.

src/server/seat_interface.cpp
1349	Redid this one too many times and overlooked this obvious problem. I will just use the last() call of the QMap instead of size(). Thanks!
src/server/seat_interface_p.h
154	Needs to be a QMap now again with the last() call in the touchDown method.

Fix id setting and cancel touch drags
Reapply position of first touch on drag

Harbormaster completed remote builds in B3000: Diff 41923.Sep 19 2018, 12:35 AM

davidedmundson accepted this revision.Oct 30 2018, 12:44 PM

This revision is now accepted and ready to land.Oct 30 2018, 12:44 PM

No touch motion on drag
Add touch dnd autotest

Harbormaster completed remote builds in B4754: Diff 45164.Nov 9 2018, 10:50 AM

romangg mentioned this in D15466: Add Wayland touch drag and drop support.Nov 9 2018, 10:56 AM

Closed by commit R127:09b5adee94ad: [server] Touch drag support (authored by romangg). · Explain WhyDec 2 2018, 8:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_drag_drop.cpp (109 lines)
M			src/server/datadevice_interface.cpp (48 lines)
M			src/server/seat_interface.h (7 lines)
M			src/server/seat_interface.cpp (68 lines)
M			src/server/seat_interface_p.h (5 lines)
M			src/server/touch_interface.cpp (4 lines)

Diff 46753

autotests/client/test_drag_drop.cpp

Loading...

src/server/datadevice_interface.cpp

Loading...

src/server/seat_interface.h

Loading...

src/server/seat_interface.cpp

Loading...

src/server/seat_interface_p.h

Loading...

src/server/touch_interface.cpp

Loading...