| cfeck | |
| teran |
| KDE Applications |
Fixes "wrong" behavior to the correct one as described in the bug report.
Before the fix pressing "10 * / 5 =" normally would result in 20 (Stack: (10,*), (10,/), (5,=)) but with those changes it results in 2 (Stack: (10, /), (5, =)).
Internally this is achieved by "blocking" node adding after a operator (*,-,/,...) has been pressed until a number is entered. If another operator is pressed whilst blocked the top (last) operator is changed instead.
BUG: 57349
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| kcalc_core.h | ||
|---|---|---|
| 110 | I'm not sure we have much people to agree/disagree if this is how it should work, but let's fix style issues first :) Please don't make a public member variable, use getter/setter like the rest of the code does. | |
Sure. This patch was just something I've been using for a while now and found it very useful. So I just put it out there after seeing that rather old bug report from 2003.
Update: Made the bool field private and use getter/setter.
| kcalc.cpp | ||
|---|---|---|
| 2059 | The indentation is inconsistent with surrounding code. | |