Differential D15434

remove brightness contrast in favor of opacity
ClosedPublic
Actions

Authored by astippich on Sep 11 2018, 6:52 PM.

Details

Reviewers
mgallien
Commits
R255:08ff2fe592ab: remove brightness contrast in favor of opacity
Summary

minor code simplification for playlistentry, remove extra brightness contrast item and just change the opacity of the album/error icon instead

Diff Detail

Repository
R255 Elisa
Branch
remove_contrast
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2732
Build 2750: arc lint + arc unit
astippich requested review of this revision.Sep 11 2018, 6:52 PM
astippich created this revision.
astippich added a comment.Sep 11 2018, 6:54 PM

Before

After

mgallien accepted this revision.Sep 11 2018, 8:04 PM

Thanks

This revision is now accepted and ready to land.Sep 11 2018, 8:04 PM
Closed by commit R255:08ff2fe592ab: remove brightness contrast in favor of opacity (authored by astippich). · Explain WhySep 13 2018, 5:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qml/PlayListEntry.qml (20 lines)

Diff 41430

View Options

src/qml/PlayListEntry.qml

Loading...