Differential D1538

[libinput] Add a wrapper class Device for a libinput_device
ClosedPublic
Actions

Authored by graesslin on May 4 2016, 11:47 AM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R108:4d7134f6c74a: [libinput] Add a wrapper class Device for a libinput_device

Summary

The Device class wraps all the information we can get from libinput
about the device, like whether it's a keyboard, pointer, touch, etc.

In addition some more information is queried to figure out how "useful"
a device is. For a keyboard all alphanumeric keys are checked whether
they exist, for a pointer all (normal) buttons are queried.

All the information is exposed as Q_PROPERTY and used by the
DebugConsole. The DebugConsole gained a new tab "Input Devices" which
renders all devices and their properties in a tree view. When plugging
in/out a device, the model gets reset, so it's always up to date.

The new Device class can be used in future to configure the device,
e.g. disable touch pad, set mouse acceleration, etc.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 3638.May 4 2016, 11:47 AM

graesslin retitled this revision from to [libinput] Add a wrapper class Device for a libinput_device.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMay 4 2016, 11:47 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Debug console with two "keyboards" exposed. Sorry for phone camera foto - we are lacking proper screenshot support on Wayland.

broulik added a subscriber: broulik.May 4 2016, 12:10 PM

broulik added inline comments.

debug_console.cpp
399	Those should have some context
419	Those are not tested/supported in the Device constructor
libinput/device.cpp
26	using namespace?

graesslin added inline comments.May 4 2016, 12:36 PM

debug_console.cpp
419	Yes, I decided to map all buttons here.

i18nc
config features exposed

graesslin marked an inline comment as done.May 4 2016, 1:09 PM

Also get whether the device can be disabled

Looks good to me.

I've tested it on my laptop, and it shows all kind of devices, generally the output makes sense. When turning the laptop into tablet mode, nothing seems to happen to the keyboard device. It could be that it's just physically blocked (there's a neat mechanism which elevates the keyboard backplate so it's flush with the keys, keys are at that point not pressable anymore (also nothing shown in the debug console) as expected. Trackpoint and touchpad + buttons still work (also expected).

The window size of the debug console is a bit small on my display, it only covers about ten lines of the view, and I can't seem to resize the debug console window, so it's a bit fiddly.

In D1538#28537, @sebas wrote:

Looks good to me.

I've tested it on my laptop, and it shows all kind of devices, generally the output makes sense. When turning the laptop into tablet mode, nothing seems to happen to the keyboard device. It could be that it's just physically blocked (there's a neat mechanism which elevates the keyboard backplate so it's flush with the keys, keys are at that point not pressable anymore (also nothing shown in the debug console) as expected. Trackpoint and touchpad + buttons still work (also expected).

pity :-( but somehow I expected that.

The window size of the debug console is a bit small on my display, it only covers about ten lines of the view, and I can't seem to resize the debug console window, so it's a bit fiddly.

Yeah, I need to look into making it a proper window. So far KWin had never been able to manage it's own windows. Now with Wayland that becomes a possibility.

Closed by commit R108:4d7134f6c74a: [libinput] Add a wrapper class Device for a libinput_device (authored by graesslin). · Explain WhyMay 6 2016, 6:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (1 line)
M		debug_console.h (17 lines)
M		debug_console.cpp (204 lines)
M		debug_console.ui (10 lines)
M		libinput/connection.h (8 lines)
M		libinput/connection.cpp (32 lines)
A	M	libinput/device.h (164 lines)
A	M	libinput/device.cpp (127 lines)
M		tests/CMakeLists.txt (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	3638	d19690c		May 4 2016, 11:47 AM	★	★
Diff 2	3640	d19690c	* i18nc	May 4 2016, 1:08 PM	★	★
Diff 3	3641	d19690c	Also get whether the device can be disabled	May 4 2016, 2:04 PM	★	★
Diff 4	3654	731e9c8	rKWIN4d7134f6c74a5361467f559db2f84dcd6a206dbf	May 6 2016, 6:21 AM	★	★