Fix tab attach/reattach and simplify tab dnd code
ClosedPublic

Authored by tcanabrava on Sun, Sep 9, 3:47 PM.

Details

Summary

This continues the patch series of the rewrite
of the Tab handling code to a more modern approach
using QTabWidget.

This fixes the attach and reattach bug on multiple
konsole windows and reworks the drag & drop code
to a more simplified version of it.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava requested review of this revision.Sun, Sep 9, 3:47 PM
tcanabrava created this revision.
lbergdoll added inline comments.
src/ViewManager.cpp
652

Return value?

lbergdoll added inline comments.Sun, Sep 9, 8:06 PM
src/ViewManager.cpp
652

Nvm, somehow confused sides.

looks fine ATM - let me test it some more - I'll go through the others this weekend

hindenburg accepted this revision.Sun, Sep 16, 4:36 PM
hindenburg retitled this revision from Fixes Handling of Tabs after the rewrite to Fix tab attach/reattach and simplify tab dnd code.
hindenburg edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sun, Sep 16, 4:36 PM
This revision was automatically updated to reflect the committed changes.