Differential D15252

[KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon
ClosedPublic
Actions

Authored by broulik on Sep 3 2018, 8:42 PM.

Details

Reviewers
davidedmundson
apol
Group Reviewers
Frameworks
VDG
Commits
R241:f27ac45b52c0: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon
Summary

The former knows high dpi scaling

Test Plan

Before


After

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 3 2018, 8:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 3 2018, 8:42 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 3 2018, 8:42 PM
apol accepted this revision.Sep 3 2018, 10:03 PM
This revision is now accepted and ready to land.Sep 3 2018, 10:03 PM
Closed by commit R241:f27ac45b52c0: [KPropertiesDialog] Use QIcon::fromTheme rather than KIconLoader::loadIcon (authored by broulik). · Explain WhySep 4 2018, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kpropertiesdialog.cpp (2 lines)

Diff 40953

View Options

src/widgets/kpropertiesdialog.cpp

Loading...