Differential D15217

Tune KeywordList lookup & avoid allocations for implicit capture group
ClosedPublic
Actions

Authored by cullmann on Sep 2 2018, 11:03 AM.

Details

Reviewers
vkrause
dhaumann
Commits
R216:a492c36d3ca5: Tune KeywordList lookup & avoid allocations for implicit capture group
Summary

No longer any allocations, we use sorted vectors for lookup.
Init sorted vectors lazy, but no longer as lazy that mutable members are needed.

Test Plan

make && make test works
perf looks nicer afterwards

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
cullmann created this revision.Sep 2 2018, 11:03 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 2 2018, 11:03 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Sep 2 2018, 11:03 AM

perf before:

perf.xZfpV.svg154 KBDownload
perf.xZfpV.txt35 KBDownload

cullmann added a comment.Sep 2 2018, 11:04 AM

perf after the change

perf.2U8ac.svg62 KBDownload
perf.2U8ac.txt14 KBDownload

cullmann added a comment.Sep 2 2018, 11:05 AM

And yes, the skip offset lookup is still deadly ;=)

8.27%     8.27%  highlighter_ben  libKF5SyntaxHighlighting.so.5.50.0  [.] QHash<KSyntaxHighlighting::Rule*, int>::findNode
cullmann updated this revision to Diff 40852.Sep 2 2018, 11:34 AM

Avoid saving the implicit capture group 0 on each regex match.
That avoids allocating the match string each time (and the non-empty list).
One anyways shall only access capture group >= 1

cullmann retitled this revision from Tune KeywordList lookup to Tune KeywordList lookup & avoid allocations for implicit capture group.Sep 2 2018, 11:34 AM

Now the QRegularExpression::match call is the real offender allocation wise.

vkrause accepted this revision.Sep 2 2018, 2:49 PM
This revision is now accepted and ready to land.Sep 2 2018, 2:49 PM
Closed by commit R216:a492c36d3ca5: Tune KeywordList lookup & avoid allocations for implicit capture group (authored by cullmann). · Explain WhySep 2 2018, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mdata/schema/language.xsd (6 lines)
Msrc/lib/rule.cpp (57 lines)

Diff 40852

View Options

data/schema/language.xsd

Loading...
View Options

src/lib/rule.cpp

Loading...