Differential D15164

Support button icons when present
ClosedPublic
Actions

Authored by mart on Aug 30 2018, 11:23 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R242:85cab5772c56: Support button icons when present
Summary

support button icons.
if there is no icon or is Qt 5.9, the iconItem will stay invisible

Test Plan

tested with ported mediacontroller to PlasmaComponents3

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
phab/icons
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 2349
Build 2367: arc lint + arc unit
mart created this revision.Aug 30 2018, 11:23 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 30 2018, 11:23 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Aug 30 2018, 11:23 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2018, 12:07 PM
Closed by commit R242:85cab5772c56: Support button icons when present (authored by mart). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 40694

View Options

src/declarativeimports/plasmacomponents3/Button.qml

Loading...
View Options

src/declarativeimports/plasmacomponents3/ToolButton.qml

Loading...