Support button icons when present
ClosedPublic
Actions

Authored by mart on Aug 30 2018, 11:23 AM.

Details

Reviewers

None

Group Reviewers

Plasma

Commits

R242:85cab5772c56: Support button icons when present

Summary

support button icons.
if there is no icon or is Qt 5.9, the iconItem will stay invisible

Test Plan

tested with ported mediacontroller to PlasmaComponents3

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mart requested review of this revision.Aug 30 2018, 11:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 6 2018, 12:07 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/declarativeimports/plasmacomponents3/Button.qml (26 lines)
M			src/declarativeimports/plasmacomponents3/ToolButton.qml (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40694	56f0df4		Aug 30 2018, 11:23 AM	★	★
Diff 2	41100	bedd597	R242:85cab5772c560ea248c490d9d58db87296dec06b	Sep 6 2018, 12:06 PM	★	★