Changes the tabName function to return the name of the passed in
DolphinTabPage. Previously it would return the name of the active tab,
which causes in-active tabs to get the wrong name.
Details
Details
- Reviewers
ngraham elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:5a9567730d37: Changes the tabName function to return the name of a specific tab
Open Dolphin
Right click a folder and select 'Open in new tab'
Notice that the new tab has the wrong title
BUG: 397910
Diff Detail
Diff Detail
- Repository
- R318 Dolphin
- Branch
- fixes_bug_397910
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 2428 Build 2446: arc lint + arc unit
Comment Actions
Thanks, this fixes the issue and doesn't seem to introduce any regressions in my testing.
Let's wait for Elvis this time. :)
| src/dolphintabwidget.cpp | ||
|---|---|---|
| 359 ↗ | (On Diff #40533) | We usually use if (!tabPage) |