Replace deprecated use of QWeakPointer<QObject*> in favor of QPointer<QObject*>

Authored by dcaliste on Aug 27 2018, 2:59 PM.



QWeakPointer has been deprecated to store pointers on QObject. QPointer should be used instead.

Diff Detail

R8 Calligra
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
dcaliste created this revision.Aug 27 2018, 2:59 PM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald TranscriptAug 27 2018, 2:59 PM
dcaliste requested review of this revision.Aug 27 2018, 2:59 PM
dcaliste updated this revision to Diff 40514.Aug 27 2018, 3:13 PM

Propagate changes into filters: missing conversion from QSharedPointer into QPointer.

Adding in Camilla, because text :)

I have no fundamentally against it, but I cannot test it right - so if it works 'm all for it

leinir accepted this revision.Aug 31 2018, 12:47 PM

In that case, things build and run fine for me, and while i can't comment on performance here, i understand that making QPointer sufficiently performant was basically why QWeakPointer was deprecated anyway, so... shipit! :)

This revision is now accepted and ready to land.Aug 31 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.