Differential D15099

add a new property headerVisible
ClosedPublic
Actions

Authored by mart on Aug 27 2018, 12:13 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Frameworks
Commits
R236:9069ae42435c: add a new property headerVisible
Summary

add a new property in KPageWidgetItem, headerVisible
this way the page can control whether or not make its own header
visible.
This is necessary for the new systemsettings in which the new
QML kcms display their own title, but the old QWidget based ones
don't and have the KPageWidget display it for them.

Test Plan

tested in systemsettings

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Aug 27 2018, 12:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 27 2018, 12:13 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mart requested review of this revision.Aug 27 2018, 12:13 PM
mart added a reviewer: Frameworks.Aug 27 2018, 12:13 PM

KCM showing its own title


Ttile shown by KPageWidget

mart updated this revision to Diff 40504.Aug 27 2018, 12:34 PM
  • emit changed
abetts added a subscriber: abetts.Aug 27 2018, 2:17 PM

Thanks for the work Marco!

davidedmundson accepted this revision.Aug 28 2018, 1:03 PM
This revision is now accepted and ready to land.Aug 28 2018, 1:03 PM
Closed by commit R236:9069ae42435c: add a new property headerVisible (authored by mart). · Explain WhyOct 10 2018, 9:44 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Path
No data available.

Diff 43278