[RFC] Remove HTML thumbnailer
ClosedPublic
Actions

Authored by broulik on Aug 27 2018, 11:23 AM.

Details

Reviewers

dfaure
fvogt
anthonyfieroni

Commits

R320:be71c2c3d5a1: Remove HTML thumbnailer

Summary

QtWebEngine doesn't support rendering into a pixmap.
Using WebKit or any other old and unmaintained library is dangerous as a bug could be exploited by a malicious HTML file present on the system.

Test Plan

I don't see how this could have ever worked. I tried to fix it but it would just crash when doing view->render()

Diff Detail

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik requested review of this revision.Aug 27 2018, 11:23 AM

broulik created this revision.

broulik retitled this revision from Remove HTML thumbnailer to [RFC] Remove HTML thumbnailer.

fvogt edited the summary of this revision. (Show Details)Aug 27 2018, 11:25 AM

It looks like i'm not test it when i port it.

This revision is now accepted and ready to land.Aug 27 2018, 11:54 AM

I get the same result: This is not possible to achieve using Qt WebEngine. See upstream bug https://bugreports.qt.io/browse/QTBUG-46129

It's possible to get a QImage of a webpage only by using the view's grabWindow() method, but only if the view is visible. Technically it might be possible with the offscreen QPA, but that doesn't support EGL which WebEngine needs.

Closed by commit R320:be71c2c3d5a1: Remove HTML thumbnailer (authored by broulik). · Explain WhyAug 28 2018, 7:08 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		thumbnail/CMakeLists.txt (24 lines)
D	M	thumbnail/htmlcreator.h (53 lines)
D	M	thumbnail/htmlcreator.cpp (108 lines)
D	M	thumbnail/htmlthumbnail.desktop (99 lines)