| davidedmundson |
| KWin |
A drag start request should be dismissed when the client does not have an
implicit pointer grab or the currently focused pointer surface is not the
origin. The conditions for that were wrong in the past.
Also just ignore the request and not post directly an error, that potentially
kills the client since by concurrency the client might have send a valid
request, that got invalidated through grab or focus change at the same time
on the server side.
Manually and autotest.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I updated the autotest. Note that the old autotest was broken anyway because the wrong pointer button serial was used when the drag was started and by that aborted in SeatInterface. The new test fails on testDragInternally with:
QFATAL : TestDataDevice::testDragInternally(grab and focus) ASSERT: "source" in file /home/roman/dev/kde/src/frameworks/kwayland/src/server/dataoffer_interface.cpp, line 153 FAIL! : TestDataDevice::testDragInternally(grab and focus) Received a fatal error.
what is a different problem. A data offer should not be created when there is no data source. The old autotest did not capture this problem, since the drag was aborted on the SeatInterface.
| src/server/datadevice_interface.cpp | ||
|---|---|---|
| 103–104 | this looks like it's still missing a !, based on the explanation "when the client does not have an implicit pointer grab" | |
| src/server/datadevice_interface.cpp | ||
|---|---|---|
| 103–104 | There is a ! in the beginning. Or did you mean something else? | |
| src/server/datadevice_interface.cpp | ||
|---|---|---|
| 103–104 | I need new glasses :) | |