hunspell: Restore build with hunspell <=v1.5.0
ClosedPublic
Actions

Authored by kfunk on Aug 22 2018, 7:47 AM.

Details

Reviewers

rjvbb
dfaure
mlaurent

Commits

R246:a18b3810a18d: hunspell: Restore build with hunspell <=v1.5.0

Summary

Commit 0a96acf251baa5c9dd042d093ab2bf8fcee10502 broke compatibility with
hunspell versions earlier than v1.5.1. v1.5.1 is was released Nov 2016,
thus only two years old.

This patch restores the build with hunspell versions provided on more
conservative platforms (e.g. CentOS 6.8, which provides hunspell v1.2.x)

Diff Detail

Repository

R246 Sonnet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kfunk created this revision.Aug 22 2018, 7:47 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptAug 22 2018, 7:47 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kfunk requested review of this revision.Aug 22 2018, 7:47 AM

Harbormaster completed remote builds in B2104: Diff 40190.Aug 22 2018, 7:47 AM

kfunk added reviewers: rjvbb, dfaure, mlaurent.Aug 22 2018, 7:51 AM

dfaure accepted this revision.Aug 22 2018, 8:14 AM

dfaure added inline comments.

src/plugins/hunspell/hunspelldict.cpp
130	lst.reserve(nbWord);

This revision is now accepted and ready to land.Aug 22 2018, 8:14 AM

kfunk added inline comments.Aug 22 2018, 8:29 AM

src/plugins/hunspell/hunspelldict.cpp
130	Note: That's just old/copied code. Unlikely to be called on recent distros anyway.

Closed by commit R246:a18b3810a18d: hunspell: Restore build with hunspell <=v1.5.0 (authored by kfunk). · Explain WhyAug 22 2018, 9:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/plugins/hunspell/CMakeLists.txt (9 lines)
A	M	src/plugins/hunspell/config-hunspell.h.cmake (1 line)
M		src/plugins/hunspell/hunspelldict.cpp (21 lines)