Differential D14946

[DialogShadows] Use 0 offset for disabled borders on Wayland
ClosedPublic
Actions

Authored by zzag on Aug 20 2018, 10:49 AM.

Details

Reviewers
davidedmundson
Commits
R242:8497832a8bf0: [DialogShadows] Use 0 offset for disabled borders on Wayland
Summary

On Wayland, DialogShadows doesn't attach empty tiles for disabled
borders. Yet, it sets offset of 1 for them. This results in visual
artifacts like this

KWin thinks that there is 1px tall shadow in the bottom.

In general we don't need to pass empty shadow tiles for disabled
borders. Thus, that's fine to set 0 offset for them.

Test Plan
  • Started kwin_wayland:

    dbus-launch kwin_wayland --windowed --xwayland
  • Launched latte-dock and kate:

    unset DISPLAY QT_QPA_PLATFORM=wayland latte-dock & QT_QPA_PLATFORM=wayland kate
  • Opened calendar popup:

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 20 2018, 10:49 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 20 2018, 10:49 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
zzag requested review of this revision.Aug 20 2018, 10:49 AM
davidedmundson accepted this revision.Aug 21 2018, 10:34 AM
This revision is now accepted and ready to land.Aug 21 2018, 10:34 AM
zzag updated this revision to Diff 40150.Aug 21 2018, 1:06 PM

"QMarginsF margins = QMarginsF();" => "QMarginsF margins;"

zzag added a comment.Aug 21 2018, 1:10 PM

This change depends on D14783.

I also think that we don't need to attach empty tiles on X11. But it works, the Sliding Popups effect was fixed... So, maybe, that's fine.

davidedmundson added a comment.Aug 21 2018, 1:12 PM

Yeah, I'm reviewing that now, it just has a lot of maths to get through :)

zzag added a comment.Aug 31 2018, 2:39 PM

I suppose it has to go in 5.51 (tagging will be tomorrow).

Closed by commit R242:8497832a8bf0: [DialogShadows] Use 0 offset for disabled borders on Wayland (authored by zzag). · Explain WhySep 3 2018, 4:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/plasmaquick/dialogshadows.cpp (2 lines)

Diff 40929

View Options

src/plasmaquick/dialogshadows.cpp

Loading...