Differential D14938

Force ki18n to build with the libintl.so path
ClosedPublic
Actions

Authored by sdepiets on Aug 20 2018, 4:18 AM.

Details

Reviewers
vonreth
bcooksley
arichardson
Group Reviewers
Craft
Frameworks
Commits
R877:ccfb970b3206: Force ki18n to build with the libintl.so path
Summary

Currently, Ki18n doesn't build with a clang setup because it doesn't reference the libintl.so file built and installed with craft.
I'm not sure this is the correct way to solve this issue.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sdepiets requested review of this revision.Aug 20 2018, 4:18 AM
sdepiets created this revision.
sdepiets edited the summary of this revision. (Show Details)Aug 20 2018, 4:19 AM
sdepiets added a reviewer: Craft.
sdepiets added a project: Craft.
sdepiets added a reviewer: vonreth.Aug 22 2018, 3:47 AM

Same issue with GCC

vonreth added a comment.Aug 22 2018, 6:07 AM

hm we need a different solution..

vonreth added a comment.Aug 25 2018, 4:12 PM

Does anyone know why it prevents the usage of libintl?
And if there is a specific reason for that behaviour should we stop providing gettext on mac?

sars added a subscriber: sars.Sep 14 2018, 10:23 AM

If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it.

sdepiets added a comment.Sep 14 2018, 11:00 AM
In D14938#325850, @sars wrote:

If I understand the comments correct it assumes that if we use a libc that already has what we need, we don't need to use a separate library for it.

Correct me if I'm wrong, but I don't think "if(LibIntl_SYMBOL_FOUND)" discriminates between whether that symbol came from libc or not.

sdepiets added a comment.Sep 14 2018, 11:01 AM
This comment was removed by sdepiets.
vonreth accepted this revision.Oct 19 2018, 4:39 PM

its not optimal to patch this on our side but lets do it for now

This revision is now accepted and ready to land.Oct 19 2018, 4:39 PM
Closed by commit R877:ccfb970b3206: Force ki18n to build with the libintl.so path (authored by sdepiets, committed by vonreth). · Explain WhyOct 19 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43947

View Options

kde/frameworks/tier1/ki18n/0002-Keep-LibIntl-libraries-path.patch

Loading...
View Options

kde/frameworks/tier1/ki18n/ki18n.py

Loading...