Details

Reviewers

Group Reviewers

Commits

Summary

Fixing menu items, strings with a box and Capitalization
Add "@title:window" marker; format and identation fixes
Replace EXIF and exif occurrences to Exif

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

There are a very large number of changes, so older changes are hidden. Show Older Changes

Harbormaster completed remote builds in B2384: Diff 40764.Aug 31 2018, 1:09 PM

Solved!

Harbormaster completed remote builds in B2411: Diff 40822.Sep 1 2018, 2:15 PM

johanneszarl added a subscriber: johanneszarl.Sep 3 2018, 7:54 PM

I've added some suggestions inline. If @pino gives his ok I'm happy to accept this...

AnnotationDialog/Dialog.cpp
601	This could be clearer written as "@title:window image %1 of %2 images"
Settings/ExifPage.cpp
39	Do the same capitalization rules as for EXIF apply for IPTC? (Although I have to say "Iptc" is barely readable compared to "IPTC"...
Viewer/ViewerWidget.cpp
494	I don't know if it's worth mentioning at this place, but the "detail" parameter is usually the zoom factor (e.g. "[ Zoom x1.3]") as set in Viewer::ImageDisplay::updateZoomCaption()...

I stopped at Viewer/ViewerWidget.cpp, but the main point is: please do not add whitespace/indentation changes to this patch. This patch is already big because of all the i18n changes, no need to make it way bigger by adding unrelated changes; they make it harder to review what was the actual topic of the commit.

AnnotationDialog/Dialog.cpp
241	extra whitespace changes
342–349	extra whitespace changes
819–824	extra whitespace changes
AnnotationDialog/ImagePreviewWidget.cpp
89 ↗	(On Diff #40822)	extra whitespace changes
322–325 ↗	(On Diff #40822)	extra whitespace/indentation changes
AnnotationDialog/ListSelect.cpp
727 ↗	(On Diff #40822)	extra whitespace/indentation changes
AnnotationDialog/ResizableFrame.cpp
487 ↗	(On Diff #40822)	extra whitespace/indentation changes
518 ↗	(On Diff #40822)	extra whitespace/indentation changes
526 ↗	(On Diff #40822)	extra whitespace/indentation changes
BackgroundTaskManager/JobModel.cpp
98–101 ↗	(On Diff #40822)	extra whitespace changes
Browser/AbstractCategoryModel.cpp
46–48 ↗	(On Diff #40822)	extra whitespace changes
Browser/Breadcrumb.cpp
36 ↗	(On Diff #40822)	extra whitespace changes
Browser/OverviewPage.cpp
169	extra whitespace changes
300	extra whitespace changes
DB/ImageDate.cpp
351–356 ↗	(On Diff #40822)	extra whitespace changes
DB/ImageSearchInfo.cpp
270 ↗	(On Diff #40822)	extra whitespace changes
283 ↗	(On Diff #40822)	extra whitespace changes
DateBar/DateBarWidget.cpp
100–108 ↗	(On Diff #40822)	extra whitespace changes
708 ↗	(On Diff #40822)	extra whitespace changes
Exif/InfoDialog.cpp
41	extra whitespace changes
Exif/ReReadDialog.cpp
41	extra whitespace changes
Exif/SearchDialog.cpp
40	extra whitespace changes
84	extra whitespace changes
93	extra whitespace changes
149	extra whitespace changes
400	extra whitespace changes
Exif/SearchInfo.cpp
183–188 ↗	(On Diff #40822)	extra whitespace changes
HTMLGenerator/HTMLDialog.cpp
63	extra whitespace changes
125–130	extra whitespace changes
569	extra whitespace changes
ImportExport/Export.cpp
83	extra whitespace changes
ImportExport/ImportDialog.cpp
149 ↗	(On Diff #40822)	extra whitespace changes
MainWindow/AutoStackImages.cpp
49	extra whitespace changes
83–93	extra whitespace changes
MainWindow/DeleteDialog.cpp
36	extra whitespace changes
MainWindow/FeatureDialog.cpp
42	extra whitespace changes
223–224	extra whitespace changes
MainWindow/InvalidDateFinder.cpp
43	extra whitespace changes
80	extra whitespace changes
MainWindow/RunDialog.cpp
78–80 ↗	(On Diff #40822)	extra whitespace changes
MainWindow/SearchBar.cpp
32 ↗	(On Diff #40822)	extra whitespace changes
MainWindow/StatisticsDialog.cpp
137 ↗	(On Diff #40822)	extra whitespace changes
178 ↗	(On Diff #40822)	extra whitespace changes
MainWindow/TokenEditor.cpp
40	extra whitespace changes
MainWindow/Window.cpp
753	extra whitespace changes
1290	extra whitespace changes
1850–1854	extra whitespace/indentation changes
Plugins/CategoryImageCollection.cpp
32 ↗	(On Diff #40822)	extra whitespace changes
Plugins/ImageCollection.cpp
48–61 ↗	(On Diff #40822)	extra whitespace changes
Settings/ExifPage.cpp
39	No, compare the two: https://en.wikipedia.org/wiki/International_Press_Telecommunications_Council https://en.wikipedia.org/wiki/Exif
Settings/FileVersionDetectionPage.cpp
151	extra whitespace changes
Settings/GeneralPage.cpp
49–51	extra whitespace changes
Settings/SettingsDialog.cpp
103	extra whitespace changes
Settings/TagGroupsPage.cpp
49 ↗	(On Diff #40822)	extra whitespace changes
58 ↗	(On Diff #40822)	extra whitespace changes
69 ↗	(On Diff #40822)	extra whitespace changes
78 ↗	(On Diff #40822)	extra whitespace changes; also, here the space between "group" and "..." should be removed
258–260 ↗	(On Diff #40822)	extra whitespace changes
340–342 ↗	(On Diff #40822)	extra whitespace/indentation changes
359–376 ↗	(On Diff #40822)	extra whitespace/indentation changes
466–483 ↗	(On Diff #40822)	extra whitespace/indentation changes
500 ↗	(On Diff #40822)	extra whitespace changes
563–568 ↗	(On Diff #40822)	extra whitespace changes
746–748 ↗	(On Diff #40822)	extra whitespace changes
759–760 ↗	(On Diff #40822)	extra whitespace changes
814 ↗	(On Diff #40822)	extra whitespace/indentation changes; also, this KGuiItem here can be replaced by KStandardGuiItem::del()
Settings/ThumbnailsPage.cpp
103	extra whitespace changes
ThumbnailView/Delegate.cpp
251 ↗	(On Diff #40822)	extra whitespace changes
Utilities/Util.cpp
120–134 ↗	(On Diff #40822)	extra whitespace changes
Viewer/CategoryImageConfig.cpp
47 ↗	(On Diff #40822)	extra whitespace changes
56–80 ↗	(On Diff #40822)	extra whitespace changes
Viewer/SpeedDisplay.cpp
45–51 ↗	(On Diff #40822)	extra whitespace changes
71 ↗	(On Diff #40822)	extra whitespace changes
Viewer/ViewerWidget.cpp
145–165	extra whitespace changes
190–217	extra whitespace changes

This revision now requires changes to proceed.Sep 4 2018, 4:39 AM

@Abella: Do you know if/when you can continue with the patch? It touches quite many files and I don't want to make your work harder by changing too much in KPhotoAlbum while you work on it...

@johanneszarl: I will have time tomorrow to do it

Cool, thanks in advance!

Fixing menu items, strings with a box and Capitalization
Add "@title:window" marker
Replace EXIF and exif occurrences to Exif

Harbormaster completed remote builds in B3438: Diff 42758.Oct 2 2018, 9:55 PM

Looks good to me now, thanks for all the effort!

This revision is now accepted and ready to land.Oct 3 2018, 4:11 AM

Thanks again to you both! I've taken the liberty to land the patch...

Closed by commit R463:184940183d75: l10n fixes (authored by Abella, committed by johanneszarl). · Explain WhyOct 3 2018, 9:26 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			AnnotationDialog/Dialog.cpp (22 lines)
M			BackgroundTaskManager/JobViewer.cpp (2 lines)
M			Browser/OverviewPage.cpp (2 lines)
M			ChangeLog (52 lines)
M			DB/FileInfo.cpp (2 lines)
M			DB/ImageInfo.cpp (2 lines)
M			DB/NewImageFinder.cpp (12 lines)
M			Exif/Database.cpp (2 lines)
M			Exif/Info.cpp (2 lines)
M			Exif/InfoDialog.cpp (4 lines)
M			Exif/ReReadDialog.cpp (12 lines)
M			Exif/SearchDialog.cpp (4 lines)
M			HTMLGenerator/HTMLDialog.cpp (2 lines)
M			ImportExport/Export.cpp (2 lines)
M			ImportExport/ImportHandler.cpp (4 lines)
M			MainWindow/AutoStackImages.cpp (2 lines)
M			MainWindow/CopyPopup.cpp (4 lines)
M			MainWindow/DeleteDialog.cpp (2 lines)
M			MainWindow/FeatureDialog.cpp (10 lines)
M			MainWindow/InvalidDateFinder.cpp (6 lines)
M			MainWindow/TokenEditor.cpp (2 lines)
M			MainWindow/Window.cpp (4 lines)
M			Settings/CategoryPage.cpp (4 lines)
M			Settings/ExifPage.cpp (4 lines)
M			Settings/FileVersionDetectionPage.cpp (2 lines)
M			Settings/GeneralPage.cpp (10 lines)
M			Settings/SettingsData.cpp (4 lines)
M			Settings/SettingsDialog.cpp (6 lines)
M			Settings/ThumbnailsPage.cpp (6 lines)
M			Settings/ViewerPage.cpp (2 lines)
M			Viewer/ViewerWidget.cpp (6 lines)
M			Viewer/VisibleOptionsMenu.cpp (2 lines)
M			XMLDB/Database.cpp (4 lines)
M			XMLDB/FileReader.cpp (2 lines)
M			main.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40012			Aug 19 2018, 7:46 PM	★	★
Diff 2	40019			Aug 20 2018, 12:10 AM	★	★
Diff 3	40071			Aug 20 2018, 6:49 PM	★	★
Diff 4	40148			Aug 21 2018, 12:58 PM	★	★
Diff 5	40385			Aug 24 2018, 10:44 PM	★	★
Diff 6	40482	f5f2637	Build confirmed and sync for arc	Aug 26 2018, 9:17 PM	★	★
Diff 7	40723	f5f2637	Fixing menu items, strings with a box and Capitalization	Aug 30 2018, 10:20 PM	★	★
Diff 8	40724	f5f2637	Fixing menu items, strings with a box and Capitalization	Aug 30 2018, 10:22 PM	★	★
Diff 9	40764	f5f2637	Arc Sync	Aug 31 2018, 1:09 PM	★	★
Diff 10	40822	f5f2637	Solved!	Sep 1 2018, 2:15 PM	★	★
Diff 11	42758	34824a8	Fixing menu items, strings with a box and Capitalization	Oct 2 2018, 9:55 PM	★	★
Diff 12	42817	34824a8	R463:184940183d753b29274fbceead237a8f7156e82a	Oct 3 2018, 8:33 PM	★	★

l10n fixes
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 40385

AnnotationDialog/Dialog.cpp

BackgroundTaskManager/JobViewer.cpp

Browser/OverviewPage.cpp

ChangeLog

DB/FileInfo.cpp

DB/ImageInfo.cpp

DB/NewImageFinder.cpp

Exif/Database.cpp

Exif/Info.cpp

Exif/InfoDialog.cpp

Exif/ReReadDialog.cpp

Exif/SearchDialog.cpp

HTMLGenerator/HTMLDialog.cpp

ImportExport/Export.cpp

ImportExport/ImportHandler.cpp

MainWindow/AutoStackImages.cpp

MainWindow/CopyPopup.cpp

MainWindow/DeleteDialog.cpp

MainWindow/FeatureDialog.cpp

MainWindow/InvalidDateFinder.cpp

MainWindow/TokenEditor.cpp

MainWindow/Window.cpp

Settings/CategoryPage.cpp

Settings/ExifPage.cpp

Settings/FileVersionDetectionPage.cpp

Settings/GeneralPage.cpp

Settings/SettingsData.cpp

Settings/SettingsDialog.cpp

Settings/ThumbnailsPage.cpp

Settings/ViewerPage.cpp

Viewer/ViewerWidget.cpp

Viewer/VisibleOptionsMenu.cpp

XMLDB/Database.cpp

XMLDB/FileReader.cpp

main.cpp

l10n fixesClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 40385

AnnotationDialog/Dialog.cpp

BackgroundTaskManager/JobViewer.cpp

Browser/OverviewPage.cpp

ChangeLog

DB/FileInfo.cpp

DB/ImageInfo.cpp

DB/NewImageFinder.cpp

Exif/Database.cpp

Exif/Info.cpp

Exif/InfoDialog.cpp

Exif/ReReadDialog.cpp

Exif/SearchDialog.cpp

HTMLGenerator/HTMLDialog.cpp

ImportExport/Export.cpp

ImportExport/ImportHandler.cpp

MainWindow/AutoStackImages.cpp

MainWindow/CopyPopup.cpp

MainWindow/DeleteDialog.cpp

MainWindow/FeatureDialog.cpp

MainWindow/InvalidDateFinder.cpp

MainWindow/TokenEditor.cpp

MainWindow/Window.cpp

Settings/CategoryPage.cpp

Settings/ExifPage.cpp

Settings/FileVersionDetectionPage.cpp

Settings/GeneralPage.cpp

Settings/SettingsData.cpp

Settings/SettingsDialog.cpp

Settings/ThumbnailsPage.cpp

Settings/ViewerPage.cpp

Viewer/ViewerWidget.cpp

Viewer/VisibleOptionsMenu.cpp

XMLDB/Database.cpp

XMLDB/FileReader.cpp

main.cpp

l10n fixes
ClosedPublic
Actions

Revision Contents
Changeset List