There is a couple of failing tests now marked as XFAIL.
I am afraid these are new bugs, but I may have missed something (I hope)
Details
Details
Diff Detail
Diff Detail
- Repository
- R8 Calligra
- Branch
- blocklayout_unittest_danders
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 1945 Build 1963: arc lint + arc unit
Comment Actions
Thanks, i really don't know how to change predefined values like 28.0 etc. i see you changed them i still not clear to me what are the new vales :)
libs/textlayout/tests/TestBlockLayout.cpp | ||
---|---|---|
497 | Can you use macro again? |
Comment Actions
What to change depends on what the number means ;)
Well in general all numbers that depends on fontsize should be changed, the rest should stay the same, but yes it is a puzzle.
Comment Actions
I like what you have done - you seem to understand the concepts, so please commit when you feel like it's working
libs/textlayout/tests/TestBlockLayout.cpp | ||
---|---|---|
333 | yes I think so |