Differential D14883

Thread messages with same reference ID together
ClosedPublic
Actions

Authored by medhefgo on Aug 16 2018, 3:05 PM.

Details

Reviewers
dvratil
Commits
R94:dc4a7feb10f0: Thread messages with same reference ID together
Summary

Thread messages with same reference ID together

Messages from github or bugzilla usually use In-Reply-To and References headers
with an ID that either doesn't actually exist or just isn't around in the
folder. In case of bugzilla, no threading happens in that case because subject
lines don't start with "Re:". github does do that, but oftentimes the subject
based threading is imprecise (by design).

Therefore create a sorted-by-date cache of messages similar to the subject
based cache and put any message we cannot perfectly thread to the very first
message with the same message ID.
What results is a flat but threaded messagelist similar to what thunderbird does.

FIXED-IN: 5.10.0
BUG: 279115

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
medhefgo created this revision.Aug 16 2018, 3:05 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 16 2018, 3:05 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
medhefgo requested review of this revision.Aug 16 2018, 3:05 PM
bruns added a subscriber: bruns.Aug 16 2018, 3:57 PM
dvratil accepted this revision.Aug 16 2018, 7:34 PM
dvratil added a subscriber: dvratil.

Many thanks for digging into this code! The code looks good. I tried it on some of my folders and the threading still looks good.

Do you have commit access? If not I can commit this in your name.

If you are going to commit yourself, please fix the missing word in one of the comments.

messagelist/src/core/model.cpp
1679

....we should not be called at all

This revision is now accepted and ready to land.Aug 16 2018, 7:34 PM
medhefgo added a comment.Aug 16 2018, 8:03 PM

I don't have commit rights. Note that the typo is copy pasted from the same comment from the subject cache part.

dvratil added a comment.Aug 16 2018, 8:05 PM
In D14883#310342, @medhefgo wrote:

I don't have commit rights. Note that the typo is copy pasted from the same comment from the subject cache part.

Can you please give me your email, so I can attribute the commit properly?

Thanks for the heads up, I'll fix it in the other message as well :)

medhefgo added a comment.Aug 16 2018, 8:14 PM

Jan Janssen <medhefgo@web.de>

Isn't there a better way to provide this information? It's kinda silly that git commit ownership info is dropped...

dvratil added a comment.Aug 16 2018, 10:00 PM

Thanks. Unfortunately, Phabricator is silly like that. I'm told that there are some improvements in the Phabricator coming soon that should improve this workflow (and maybe one day we will even have a "Merge" button here :)

Closed by commit R94:dc4a7feb10f0: Thread messages with same reference ID together (authored by medhefgo, committed by dvratil). · Explain WhyAug 16 2018, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39890

View Options

messagelist/src/core/model.cpp

Loading...
View Options

messagelist/src/core/model_p.h

Loading...