medhefgo (Jan Janssen)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 6 2018, 8:31 PM (95 w, 1 d)
Availability
Available

Recent Activity

Aug 16 2018

medhefgo added a comment to D14883: Thread messages with same reference ID together.

Jan Janssen <medhefgo@web.de>

Aug 16 2018, 8:14 PM · KDE PIM
medhefgo added a comment to D14883: Thread messages with same reference ID together.

I don't have commit rights. Note that the typo is copy pasted from the same comment from the subject cache part.

Aug 16 2018, 8:03 PM · KDE PIM
medhefgo requested review of D14883: Thread messages with same reference ID together.
Aug 16 2018, 3:05 PM · KDE PIM

Jun 17 2018

medhefgo added a comment to T9036: Checkboxes in mixed-control layouts.

I am of the opinion that the startup page doesn't really need any changes since the checkboxes and the groupbox already provide a nice visual separation. But the label headers style certainly looks way better than the proposed formlayout and has the nice side effect of getting rid of that extra "Location:" label.

Jun 17 2018, 8:53 PM · KDE Human Interface Guidelines
medhefgo added a comment to T9036: Checkboxes in mixed-control layouts.

Yes and no, I guess.

Jun 17 2018, 8:14 PM · KDE Human Interface Guidelines
medhefgo added a comment to T9036: Checkboxes in mixed-control layouts.

@ngraham KWin's "Window Manager Settings" -> Actions (and some others) gives you an idea how it would look.

Jun 17 2018, 7:41 PM · KDE Human Interface Guidelines
medhefgo added a comment to T9036: Checkboxes in mixed-control layouts.

I'd like to suggest an alternative style, somewhat like what a lot of GTK apps do: Use bold heading labels and pad the widgets belonging to those. In fact, you could even just make breeze group boxes visually present itself like that without needing to adjust things for every application.

Jun 17 2018, 3:09 PM · KDE Human Interface Guidelines

Jun 6 2018

medhefgo added a comment to D12571: Modernize Settings window.

I think group boxes themselves are perfectly fine for the job. There is no need to force everything into form layouts. The correct step, imho, is to change the way breeze draws group boxes instead. It would fit the breeze style much more to draw them with bold left-aligned labels and no borders, but have padding for the content. Similar to how gnome does things. Here's a mockup:

Jun 6 2018, 8:38 PM · Dolphin