On Wayland session, the logout screen has "ksmserver-logout-greeter
ksmserver-logout-greet" window class, so let's animate it too.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin Plasma - Commits
- R108:0a31feb3212c: [effects/logout] Animate ksmserver-logout-greeter
- Started Wayland session;
- Pressed Ctrl+Alt+Del;
- (the logout screen smoothly faded in);
- Clicked the Cancel button;
- (the logout screen smoothly faded out)
- Started X11 session;
- Pressed Ctrl+Alt+Del;
- (the logout screen smoothly faded in);
- Clicked the Cancel button;
- (the logout screen smoothly faded out)
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Started Wayland session;
...
- (the logout screen smoothly faded out) ... and then the whole thing crashed :-)
Comment Actions
Right now(without this patch), the logout screen is not animated by the logout effect on Wayland. I.e., how the logout screen appears on X11 != how the logout screen appears on Wayland.
Comment Actions
It seems:
- the WMClass is injected at a low level in the logout greeter because it has X11BypassWindowManager
- when it got moved to a separate process, WMClass stayed working because it was done at a low level, and not done by the Qt
- because it's at a low level that doesn't work with the appId in wayland shell protocol.
Maybe put that in the commit message for future readers.
Normally, I'd say we shouldn't work round other bits of Plasma, but in a sense using the ksmserver-logout-greeter is more correct.
Comment Actions
Shouldn't we then go the right way and check appId("ksmserver org.kde.ksmserver", I guess)? Shouldn't we fix ksmserver instead? Please bear in mind that I have no idea how ksmserver works under hood.