Get rid of deprecated QWeakPointer usage
ClosedPublic
Actions

Authored by broulik on Aug 14 2018, 8:45 AM.

Details

Reviewers

mart
davidedmundson

Group Reviewers

Plasma

Commits

R242:938cef210c79: Get rid of deprecated QWeakPointer usage

Summary

Replace by QPointer

Test Plan

Compiles, runs
The storage stuff compiles but isn't really tested since it relies on QMetaObject::invokeMethod but it's likely broken and unused anyway and using a QPointer in a method signature is normally not what you want to do

Repository

R242 Plasma Framework (Library)

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

broulik requested review of this revision.Aug 14 2018, 8:45 AM

This revision is now accepted and ready to land.Aug 17 2018, 1:41 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			examples/dataengines/customDataContainers/httpContainer.h (2 lines)
M			src/declarativeimports/core/colorscope.h (2 lines)
M			src/declarativeimports/core/serviceoperationstatus.h (4 lines)
M			src/declarativeimports/core/svgitem.h (2 lines)
M			src/declarativeimports/core/tooltip.h (4 lines)
M			src/declarativeimports/core/tooltipdialog.h (1 line)
M			src/declarativeimports/plasmacomponents/fullscreenwindow.h (6 lines)
M			src/declarativeimports/plasmacomponents/qmenu.h (3 lines)
M			src/plasma/pluginloader.cpp (5 lines)
M			src/plasma/private/datacontainer_p.h (2 lines)
M			src/plasma/private/storage.cpp (12 lines)
M			src/plasma/private/storage_p.h (2 lines)
M			src/plasma/private/storagethread.cpp (8 lines)
M			src/plasma/private/storagethread_p.h (10 lines)
M			src/plasma/private/svg_p.h (5 lines)
M			src/plasma/svg.cpp (2 lines)
M			src/plasmaquick/appletquickitem.h (1 line)
M			src/plasmaquick/configmodel.cpp (2 lines)
M			src/plasmaquick/configview.cpp (4 lines)
M			src/scriptengines/qml/plasmoid/containmentinterface.h (2 lines)