[Notifications] Limit notification size and add scroll bar if needed
ClosedPublic

Authored by broulik on Apr 24 2016, 8:53 PM.

Details

Reviewers
mck182
mart
Group Reviewers
Plasma: Design
Plasma
Summary

This limits the size of the notifications in the popup to 10 lines of text.
The limit was removed when it was changed to a TextEdit so text could be copied from it.

BUG: 361389
FIXED-IN: 5.7.0

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 3497.Apr 24 2016, 8:53 PM
broulik retitled this revision from to [Notifications] Limit notification size and scroll to the bottom if needed.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design, mck182.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptApr 24 2016, 8:53 PM
broulik updated this revision to Diff 3498.Apr 24 2016, 8:54 PM
broulik removed R120 Plasma Workspace as the repository for this revision.

Remove leftovers from other patch

Why can we not make it scroll?

Why can we not make it scroll?

There's no technical reason we cannot, I just haven't added it :) I'll figure something out.

mart added a subscriber: mart.Apr 25 2016, 9:21 AM

looks like you can see the top text only for a brief moment then it goes "away"?

it makes sense even tough i think there should be some way to return to top to actually read it, and this should happen only in the popup, if it's a permentent one in the history is fine to disaplay the huge one as it has already a scrollbar

Right, the limit should only be enforced in the popup. I'll add a scrollbar and leave the history unchanged.

broulik updated this revision to Diff 4405.Jun 13 2016, 4:50 PM
broulik retitled this revision from [Notifications] Limit notification size and scroll to the bottom if needed to [Notifications] Limit notification size and add scroll bar if needed.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik set the repository for this revision to R120 Plasma Workspace.

Removed the auto scrolling stuff and just added a ScrollBar. I wasted so much time on this stupid thing so I'll just leave it now.

Hooray, so we missed 5.7.

There are a few glitches left.

  1. It is possible to scroll one letter to the right, although there is a automatic line break. Compare screenshot "start of message" and "scroll right" to get an idea of the meaning. A guess: the width calculation does not include the scrollbar?
  1. I do not know if this is intended, but it does not look correct to me: There is a border around the text message text, that is not shown completely. It is only shown on the border, which contains more text. Compare the screenshots below. On the first screenshot, the border is only shown below and on the right edge. On the second screenshot it is also shown on the top. On the thirst it is shown on the left and the bottom. I think there should be no border at all

start of message:

message in the middle:

scroll right:

Thanks for your feedback

It is possible to scroll one letter to the right, although there is a automatic line break.

I suppose that's the are the scroll bar occupies, I'll have a look.

I do not know if this is intended, but it does not look correct to me: There is a border around the text message text, that is not shown completely. It is only shown on the border, which contains more text.

This is intentional. This is Plasma's way of telling you "there's more if you scroll in that direction", you can observe the same in eg. Kickoff's application list or the Widget Explorer.

PING.

If there are no objections I'll push this tomorrow. I don't want to miss yet another feature release.

mart accepted this revision.Sep 12 2016, 12:39 PM
mart added a reviewer: mart.

better to push it sooner than later

This revision is now accepted and ready to land.Sep 12 2016, 12:39 PM

Thanks for your feedback

It is possible to scroll one letter to the right, although there is a automatic line break.

I suppose that's the are the scroll bar occupies, I'll have a look.

what about this issue? It is not fixed yet.

what about this issue? It is not fixed yet.

I disabled horizontal scrolling (previously I only hid the horizontal scroll bar). Unfortunately, we often ran into an infinite loop when binding contents to the ScrollView viewport as a scroll bar might appear, which then causes the content to shrink, which then might not need a scroll bar again, etc, etc. Not super pretty but then, super long notifications are usually broken anywa.