Otherwise you'll end up with a huge notification containing all previously finished jobs.
BUG: 360156
FIXED-IN: 5.7.0
Otherwise you'll end up with a huge notification containing all previously finished jobs.
BUG: 360156
FIXED-IN: 5.7.0
Timer applet notification still works.
I also cleaned up a bit there as the "appRealName" thing doesn't deserve a dedicated parameter in the function and was never used there anyway; it's neither exposed through DBus nor as part of the notification service and thus is a private impl I can change.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore.
Only errors should be persistent.
So that users may leave long-taking jobs unattended and then click "Open folder" on the notification or something once they're back and/or the job is done.
Ah, right, that makes sense.
Not grouping them can lead to a quite long list of notifications if someone does a lot of file transfer jobs, but that's certainly the lesser of two evils.
+1 for the change, then!
i find the fact those notifications are persistent very useful, as if i have for instance a big file to upload i just abandon the machine.
when i return i prefer having something telling how the transfer went, i don't find the "no news good news" enough here
+1 from me(provided the commit excludes the osd stuff), would like Martin taking a final look at this