[Notifications] Don't group job finished notifications
ClosedPublic

Authored by broulik on Apr 24 2016, 8:35 PM.

Details

Summary

Otherwise you'll end up with a huge notification containing all previously finished jobs.

BUG: 360156
FIXED-IN: 5.7.0

Test Plan

Timer applet notification still works.

I also cleaned up a bit there as the "appRealName" thing doesn't deserve a dedicated parameter in the function and was never used there anyway; it's neither exposed through DBus nor as part of the notification service and thus is a private impl I can change.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 3496.Apr 24 2016, 8:35 PM
broulik retitled this revision from to [Notifications] Don't group job finished notifications.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, mck182, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptApr 24 2016, 8:35 PM

Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore.
Only errors should be persistent.

mck182 edited edge metadata.Apr 25 2016, 12:26 AM

Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore.
Only errors should be persistent.

So that users may leave long-taking jobs unattended and then click "Open folder" on the notification or something once they're back and/or the job is done.

In D1478#27450, @mck182 wrote:

So that users may leave long-taking jobs unattended and then click "Open folder" on the notification or something once they're back and/or the job is done.

Ah, right, that makes sense.
Not grouping them can lead to a quite long list of notifications if someone does a lot of file transfer jobs, but that's certainly the lesser of two evils.
+1 for the change, then!

Please ignore the OSD stuff in the patch :)

mart added a subscriber: mart.Apr 25 2016, 9:23 AM

Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore.
Only errors should be persistent.

i find the fact those notifications are persistent very useful, as if i have for instance a big file to upload i just abandon the machine.
when i return i prefer having something telling how the transfer went, i don't find the "no news good news" enough here

mart added a comment.Apr 25 2016, 9:27 AM

+1 from me(provided the commit excludes the osd stuff), would like Martin taking a final look at this

Ping.

Also, should we target Plasma/5.6 with that?

mart accepted this revision.May 2 2016, 11:52 AM
mart added a reviewer: mart.

go for it but only master

This revision is now accepted and ready to land.May 2 2016, 11:52 AM
This revision was automatically updated to reflect the committed changes.