Definition: Expose command markers
ClosedPublic

Authored by dhaumann on Aug 12 2018, 11:46 AM.

Details

Summary

Added functios include:

  • QString singleLineCommentMarker() const
  • CommentPosition singleLineCommentPosition() const
  • QPair<QString, QString> multiLineCommentMarker() const

Note: Some highlighting xml files define multiple singleLine and multiLine
comments. Currently, the last one wins...

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Aug 12 2018, 11:46 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 12 2018, 11:46 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Aug 12 2018, 11:46 AM

I think later we should check for not more than one marker per type in the files, but otherwise that is ok for me now.

Ok with that Volker?

cullmann accepted this revision.Aug 12 2018, 9:13 PM

> I think that is ok

This revision is now accepted and ready to land.Aug 12 2018, 9:13 PM
This revision was automatically updated to reflect the committed changes.

@vkrause We simply decided to commit this now. But a review from your side is still appreciated ;)

Does KTE only support one comment marker of each type? Then this is ok IMHO.

Does KTE only support one comment marker of each type? Then this is ok IMHO.

Yes, all others were silently discarded.
Later one should check that there is only on in the static checker.