Differential D1473

Fix Android packaging scripts to only pick respective own app binary
ClosedPublic
Actions

Authored by kossebau on Apr 23 2016, 10:15 PM.

Details

Reviewers
nienhueser
rahn
Commits
R34:573a9b2db75b: Allow trailing dir separator on path passed to create-apk.py
Summary

Currently both Behaim and Marble Maps get both binaries into the
created apk packages.

Second commit allows trailing dir separator on path passed to create-apk.py
(like happens with tab-completion ;) )

Diff Detail

Repository
R34 Marble
Branch
onlyPickOwnAndroidAppBinary
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 3486.Apr 23 2016, 10:15 PM
kossebau retitled this revision from to Fix Android packaging scripts to only pick respective own app binary.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: nienhueser, rahn.
nienhueser accepted this revision.Apr 24 2016, 2:41 PM
nienhueser edited edge metadata.

Looks good. Maybe we should also change libMarble.so to libMarbleMaps.so at some point.

This revision is now accepted and ready to land.Apr 24 2016, 2:41 PM
Closed by commit R34:573a9b2db75b: Allow trailing dir separator on path passed to create-apk.py (authored by kossebau). · Explain WhyApr 24 2016, 4:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3486

View Options

src/apps/behaim/create-apk.py

Loading...
View Options

src/apps/marble-maps/create-apk.py

Loading...