This is the patch file for Play_rhythm activity to be submitted for final evaluation of GSoC.
Details
Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Activities - Maniphest Tasks
- T1523: Port of Gtk+ activity Play Rhythm
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/activities/play_rhythm/ActivityInfo.qml | ||
---|---|---|
40 ↗ | (On Diff #39361) | if you want to hear it again. |
src/activities/play_rhythm/PlayRhythm.qml | ||
285 ↗ | (On Diff #39361) | unused? |
src/activities/play_rhythm/play_rhythm.js | ||
67 ↗ | (On Diff #39361) | I think you should not base the accuracy on the width of the items but on the time +/- an error margin |
src/activities/play_rhythm/play_rhythm.js | ||
---|---|---|
67 ↗ | (On Diff #39361) | This was the initial plan. But Animtim told that it may cause inaccuracies depending on different device's latency so it's not good to use time as a measuring parameter. Then we decided that we can use the position of note + width as the parameter. |