Play_rhythm activity
ClosedPublic

Authored by amankumargupta on Aug 9 2018, 6:27 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Activities
Maniphest Tasks
T1523: Port of Gtk+ activity Play Rhythm
Summary

This is the patch file for Play_rhythm activity to be submitted for final evaluation of GSoC.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.Aug 9 2018, 6:27 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 9 2018, 6:27 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
jjazeix added a subscriber: jjazeix.Aug 9 2018, 7:05 PM
jjazeix added inline comments.
src/activities/play_rhythm/ActivityInfo.qml
41

if you want to hear it again.

src/activities/play_rhythm/PlayRhythm.qml
286

unused?

src/activities/play_rhythm/play_rhythm.js
68

I think you should not base the accuracy on the width of the items but on the time +/- an error margin

amankumargupta added inline comments.Aug 10 2018, 2:49 AM
src/activities/play_rhythm/play_rhythm.js
68

This was the initial plan. But Animtim told that it may cause inaccuracies depending on different device's latency so it's not good to use time as a measuring parameter. Then we decided that we can use the position of note + width as the parameter.

amankumargupta marked 2 inline comments as done.Aug 10 2018, 3:50 AM
amankumargupta added inline comments.
src/activities/play_rhythm/ActivityInfo.qml
41

Added in the latest commit.

src/activities/play_rhythm/PlayRhythm.qml
286

Removed

amankumargupta edited the summary of this revision. (Show Details)Aug 11 2018, 10:32 AM
amankumargupta marked 2 inline comments as done.
amankumargupta edited the summary of this revision. (Show Details)
amankumargupta edited the summary of this revision. (Show Details)Aug 11 2018, 11:12 AM
jjazeix accepted this revision.Dec 1 2018, 12:01 PM

Code merged

This revision is now accepted and ready to land.Dec 1 2018, 12:01 PM
jjazeix closed this revision.Dec 1 2018, 12:01 PM