Differential D14712

Play_piano activity
ClosedPublic
Actions

Authored by amankumargupta on Aug 9 2018, 6:24 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Activities
Maniphest Tasks
T1522: Port of Gtk+ Play Piano
Summary

This is the patch file for Play_piano activity to be submitted for final evaluation of GSoC.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
amankumargupta created this revision.Aug 9 2018, 6:24 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 9 2018, 6:24 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
amankumargupta updated this revision to Diff 39446.Aug 11 2018, 10:52 AM
amankumargupta edited the summary of this revision. (Show Details)
amankumargupta edited the summary of this revision. (Show Details)
jjazeix added a subscriber: jjazeix.Aug 12 2018, 4:10 PM
jjazeix added inline comments.
src/activities/play_piano/ActivityInfo.qml
40

no need to say each level has 5 sublevels, there is the score showing it

src/activities/play_piano/PlayPiano.qml
67

factorisation

121

use comparisons if you compare integers to 0

amankumargupta marked 3 inline comments as done.Aug 13 2018, 1:58 PM
amankumargupta updated this revision to Diff 39598.Aug 13 2018, 2:06 PM

Factorised keyboard binding code.

jjazeix added inline comments.Aug 13 2018, 3:46 PM
src/activities/play_piano/PlayPiano.qml
83 ↗(On Diff #39446)

instead of duplicating the check on the key values, you can have isWhiteKeyPressed and isBlackKeyPressed functions, each one having its keys

jjazeix accepted this revision.Dec 1 2018, 12:01 PM
This revision is now accepted and ready to land.Dec 1 2018, 12:01 PM
jjazeix closed this revision.Dec 1 2018, 12:01 PM

code merged

Showing Only Differences

This revision modifies 4 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 39451

View Options

src/activities/play_piano/ActivityInfo.qml

Loading...
View Options

src/activities/play_piano/PlayPiano.qml

Loading...