Differential D14647

[Kicker] Look up relative entryPaths
ClosedPublic
Actions

Authored by broulik on Aug 6 2018, 12:29 PM.

Details

Reviewers
dfaure
hein
Group Reviewers
Plasma
Commits
R119:2ce76bc5ade2: [Kicker] Look up relative entryPaths
R120:0b084ab8c789: [Kicker] Look up relative entryPaths
Summary

For KCMs we get a relative entryPath() for our KService resulting in an invalid URL being created.

BUG: 397070

Test Plan

5.12? The QUrl returned from that could be invalid now (empty), not sure if that could cause any problems elsewhere?

  • Searched for "Colors", got Color KCM, successfully added it to favorites, to TM and panel (icon widget).

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Aug 6 2018, 12:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2018, 12:29 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Aug 6 2018, 12:29 PM
broulik retitled this revision from Resolve relative service entry paths to [Kicker] Look up relative entryPaths.Aug 6 2018, 12:35 PM
hein accepted this revision.Aug 6 2018, 5:23 PM
This revision is now accepted and ready to land.Aug 6 2018, 5:23 PM
Closed by commit R119:2ce76bc5ade2: [Kicker] Look up relative entryPaths (authored by broulik). · Explain WhyAug 7 2018, 9:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 39184

View Options

applets/kicker/plugin/actionlist.h

Loading...
View Options

applets/kicker/plugin/actionlist.cpp

Loading...
View Options

applets/kicker/plugin/appentry.cpp

Loading...
View Options

applets/kicker/plugin/runnermatchesmodel.cpp

Loading...