Rework scheduler startup to merge execution paths.
ClosedPublic

Authored by TallFurryMan on Aug 4 2018, 1:22 PM.

Details

Summary

Reworked Scheduler startup functions so that all execution paths use "startJobEvaluation".
Function "startJobEvaluation" is also called when clicking button "Only evaluate jobs".
D-Bus interface "resetAllJobs" is altered to execute an evaluation too.

Test Plan

In the context of starting the Scheduler, create or load a set of Scheduler Jobs.

Note there is a difference in this Test Plan between full evaluation and on-th-fly evaluation:

  • Full evaluation resets the states of all Scheduler Jobs and unconditionally refreshes the capture storage.
  • On-the-fly evaluation is lighter, does not check storage, and only applies to IDLE, EVALUATION and ABORTED jobs.

If loading, full evaluation is called after the XML load is successful.

If creating, on-the-fly evaluation is called every time a control is updated.

Not that without the fix, there is a regression with Track/Align/Focus/Guide in that context, which cannot be saved (workaround was to finish edit with a pipeline step checked).

Start the Scheduler, full evaluation is called.
This fix eliminates remaining issues with capture counts not proper in the Scheduler.
Now the correct captured frame map is transferred to the capture module and we can start fixing things there.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Aug 4 2018, 1:22 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 4 2018, 1:22 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Aug 4 2018, 1:22 PM
TallFurryMan edited the test plan for this revision. (Show Details)Aug 4 2018, 1:54 PM
mutlaqja accepted this revision.Aug 4 2018, 5:05 PM
This revision is now accepted and ready to land.Aug 4 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.