[effects/logout] Animate the disappearing of the logout screen
ClosedPublic

Authored by zzag on Aug 4 2018, 10:10 AM.

Details

Summary

Currently, the fade effect animates both the appearing and the
disappearing of the logout screen. We don't want that because
the logout effect should do that.

D14582 addresses that problem by adding "ksmserver ksmserver" window
class to the blacklist of the fade effect. With that change, only the
logout effect animates the appearing of the logout screen. But there is
a problem... If user clicks the cancel button, the logout screen
instantaneously disappears, instead of smoothly fading out.

This change addresses that problem by adding "out" animation.

Depends on D14582

Test Plan


Now, only the logout effect animates the appearing and the disappearing of the logout screen.


No smooth transitions when the logout effect is disabled.

Diff Detail

Repository
R108 KWin
Branch
effects-logout-animate-disappearing-of-logout-screen
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1502
Build 1520: arc lint + arc unit
zzag created this revision.Aug 4 2018, 10:10 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 4 2018, 10:10 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Aug 4 2018, 10:10 AM
zzag edited the test plan for this revision. (Show Details)Aug 4 2018, 10:11 AM
zzag edited the summary of this revision. (Show Details)Aug 4 2018, 10:56 AM
zzag edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Aug 7 2018, 11:10 AM
This revision is now accepted and ready to land.Aug 7 2018, 11:10 AM
This revision was automatically updated to reflect the committed changes.